Use git sha1 instead of counter tagging
#121
Conversation
RuoqingHe
requested review from
andreeaflorescu,
lauralt,
stefano-garzarella,
stsquad,
roypat,
ShadowCurse and
TimePrinciple
as code owners
There was a problem hiding this comment.
Yeah, thanks for implementing my suggestion of using sha1 instead of counter.
I suggest putting some context in the PR description and also in the commit description where we change from vXX to gYYYYY, especially to explain the reason of the changes, otherwise can be hard for reviewer to understand what we are fixing here.
What about updating the README.md too, where we used v38 as an example?
Maybe we can also add a section to mention that we used vXX till v49/v50, then switched to gYYYYY (where YYYYY=$(git show -s --format=%h))
Would it be better to use |
This is a good idea, is |
Yes, |
RuoqingHe
force-pushed
the
use-git-sha1-instead-of-explict-versioning
branch
from
436a027 to
f6da42c
Compare
Currently, there are places hard-coded and functions manually re-implemented, refactor `docker.sh` to a cleaner manner. Signed-off-by: Ruoqing He <[email protected]>
RuoqingHe
force-pushed
the
use-git-sha1-instead-of-explict-versioning
branch
from
f6da42c to
4383699
Compare
We were using `vXX` counter tagging till `v49` for x86_64 and aarch64, and `v49-riscv` for riscv64. And we have separated riscv64 from the other two to another job due to insufficient Github Action time limit (if the job failed to complete in 6 hours, it will be canceled), which end up of having two jobs. If the x86_64 and aarch64 job are finished and images are published in vN, while riscv64 job fails in that run, restarting the riscv64 job will result an absence of vN and a presence of v(N+1). So we decided to move on to git sha1 tagging strategy. Remove `latest` function and `vXX` counter tagging, and use output of ```console git show -s --format=%h ``` as the tag of images built per PR for publishing. Signed-off-by: Ruoqing He <[email protected]>
Add code for RISC-V specific tagging. Signed-off-by: Ruoqing He <[email protected]>
RuoqingHe
force-pushed
the
use-git-sha1-instead-of-explict-versioning
branch
from
4383699 to
f500dde
Compare
|
LGTM! @RuoqingHe I'd just suggest fixing also the README and add a little section that we switched from vXX to gYYYYY. |
`dev` image for x86_64 and aarch64 could be pulled through command `docker pull rustvmm/dev:latest` and for riscv64 through `docker pull rustvmm/dev:latest-riscv` for developers/users to use/test. Signed-off-by: Ruoqing He <[email protected]>
RuoqingHe
force-pushed
the
use-git-sha1-instead-of-explict-versioning
branch
from
24644a9 to
0c21d2c
Compare
Thanks for reviewing, I gather there were something wrongly configured in my workflow, I force pushed to see if it's addressed 🙂 |
Looks like that's now working, I will write them into |
Update `README.md` after we swtiched to `gYYYYY` git sha1 tagging from `vXX` counter tagging. Change example to pull an evolving `latest` for x86_64, aarch64 and `latest-riscv` for riscv64. Signed-off-by: Ruoqing He <[email protected]>
RuoqingHe
changed the title
git sha1 instead of explict versioninggit sha1 instead of counter tagging
Summary of the PR
docker.sh: Reuse code as much as possible
docker.sh: Replace counter tagging with git sha1:
We were using
vXXcounter tagging tillv49for x86_64 and aarch64,and
v49-riscvfor riscv64. And we have separated riscv64 from theother two to another job due to insufficient Github Action time limit
(if the job failed to complete in 6 hours, it will be canceled), which
end up of having two jobs. If the x86_64 and aarch64 job are finished
and images are published in vN, while riscv64 job fails in that run,
restarting the riscv64 job will result an absence of vN and a presence
of v(N+1). So we decided to move on to git sha1 tagging strategy.
Remove
latestfunction andvXXcounter tagging, and use output ofgit show -s --format=%has the tag of images built per PR for publishing.
docker.sh: Introduce RISC-V support for manual operations
ci: Add latest tag for ease of use
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commit message has max 60 characters for thesummary and max 75 characters for each description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.